Jackie-Jiang commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848878731
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/realtime/impl/json/MutableJsonIndexImpl.java:
##########
@@ -291,6 +297,19 @@ private RoaringBitmap getMatchingFlattenedDocIds(Predicate
predicate) {
}
}
+ private void record(ImmutableRoaringBitmap bitmap, FilterContext filter) {
+ InvocationRecording recording = Tracing.activeRecording();
+ if (recording.isEnabled()) {
+ recording.setColumnCardinality(_postingListMap.size());
+ recording.setFilter(FilterType.INDEX,
describeJsonPredicate(filter.getPredicate()));
+ recording.setNumDocsMatchingAfterFilter(bitmap.getCardinality());
+ }
+ }
+
+ private static String describeJsonPredicate(Predicate predicate) {
+ return predicate == null ? "?" : predicate.getLhs().getIdentifier() + ":"
+ predicate.getType() + "?";
Review Comment:
I see. But this class is only for `JSON_MATCH` predicate, so should we move
the recording into the `JsonMatchFilterOperator` (similar to `RANGE`, bitmap
etc.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
