richardstartin commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848870940
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -131,6 +131,11 @@ public DataTable processQuery(ServerQueryRequest
queryRequest, ExecutorService e
QueryContext queryContext = queryRequest.getQueryContext();
LOGGER.debug("Incoming request Id: {}, query: {}", requestId,
queryContext);
+ boolean enableTrace = queryRequest.isEnableTrace();
+ if (enableTrace) {
+ Tracing.getTracer().register(requestId);
Review Comment:
fixed
##########
pinot-core/src/main/java/org/apache/pinot/core/query/pruner/SegmentPruner.java:
##########
@@ -41,9 +43,12 @@ default List<IndexSegment> prune(List<IndexSegment>
segments, QueryContext query
return segments;
}
List<IndexSegment> selectedSegments = new ArrayList<>(segments.size());
- for (IndexSegment segment : segments) {
- if (!prune(segment, query)) {
- selectedSegments.add(segment);
+ try (InvocationScope scope = Tracing.getTracer().createScope(getClass())) {
Review Comment:
good suggestion
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
