richardstartin commented on code in PR #8485:
URL: https://github.com/apache/pinot/pull/8485#discussion_r848911057
##########
pinot-core/src/main/java/org/apache/pinot/core/operator/filter/JsonMatchFilterOperator.java:
##########
@@ -87,4 +94,20 @@ public String toExplainString() {
stringBuilder.append(",predicate:").append(_predicate.toString());
return stringBuilder.append(')').toString();
}
+
+ private void record(ImmutableRoaringBitmap bitmap) {
+ InvocationRecording recording = Tracing.activeRecording();
+ if (recording.isEnabled()) {
+ recording.setColumnName(_predicate.getLhs().getIdentifier());
+ recording.setFilter(FilterType.INDEX, describeJsonPredicate());
+ recording.setNumDocsMatchingAfterFilter(bitmap.getCardinality());
+ }
+ }
+
+ private String describeJsonPredicate() {
Review Comment:
I'll leave it this way for now (recording JSON_MATCH) because I want to
progress, but capturing the parsed filter expression was IMO a lot more
valuable than this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
