Jackie-Jiang commented on code in PR #8539:
URL: https://github.com/apache/pinot/pull/8539#discussion_r852320632
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -53,56 +52,58 @@ public class QueryRunner extends AbstractBaseCommand
implements Command {
private static final long NANO_DELTA = (long) 5E5;
private static final String CLIENT_TIME_STATISTICS = "CLIENT TIME
STATISTICS";
- @CommandLine.Option(names = {"-mode"}, required = true,
- description = "Mode of query runner
(singleThread|multiThreads|targetQPS|increasingQPS).")
+ @CommandLine.Option(names = {"-mode"}, required = true, description = "Mode
of query runner "
+ + "(singleThread|multiThreads|targetQPS|increasingQPS).")
Review Comment:
These changes do not seem to improve readability. IIRC we have disabled
these kind of auto-reformat in the `Pinot Style`, can you try re-importing the
style sheet?
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -295,15 +297,18 @@ public static QuerySummary
singleThreadedQueryRunner(PerfBenchmarkDriverConf con
List<Statistics> statisticsList = Collections.singletonList(new
Statistics(CLIENT_TIME_STATISTICS));
final long startTimeAbsolute = System.currentTimeMillis();
+ boolean timeoutReached = false;
long startTime = System.currentTimeMillis();
long reportStartTime = startTime;
int numReportIntervals = 0;
int numTimesExecuted = 0;
- while (numTimesToRunQueries == 0 || numTimesExecuted <
numTimesToRunQueries) {
+
+ while (!timeoutReached && (numTimesToRunQueries == 0 || numTimesExecuted <
numTimesToRunQueries)) {
for (String query : queries) {
if (timeout > 0 && System.currentTimeMillis() - startTimeAbsolute >
timeout) {
- LOGGER.warn("Timeout of {} sec reached. Aborting", timeout);
- throw new TimeoutException("Timeout of " + timeout + " sec reached.
Aborting");
+ LOGGER.info("Timeout of {} sec reached. Aborting", timeout);
Review Comment:
Suggest keeping it as warning. Same for other places
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
