npawar commented on code in PR #8539:
URL: https://github.com/apache/pinot/pull/8539#discussion_r852433622
##########
pinot-tools/src/main/java/org/apache/pinot/tools/perf/QueryRunner.java:
##########
@@ -295,15 +297,18 @@ public static QuerySummary
singleThreadedQueryRunner(PerfBenchmarkDriverConf con
List<Statistics> statisticsList = Collections.singletonList(new
Statistics(CLIENT_TIME_STATISTICS));
final long startTimeAbsolute = System.currentTimeMillis();
+ boolean timeoutReached = false;
long startTime = System.currentTimeMillis();
long reportStartTime = startTime;
int numReportIntervals = 0;
int numTimesExecuted = 0;
- while (numTimesToRunQueries == 0 || numTimesExecuted <
numTimesToRunQueries) {
+
+ while (!timeoutReached && (numTimesToRunQueries == 0 || numTimesExecuted <
numTimesToRunQueries)) {
for (String query : queries) {
if (timeout > 0 && System.currentTimeMillis() - startTimeAbsolute >
timeout) {
- LOGGER.warn("Timeout of {} sec reached. Aborting", timeout);
- throw new TimeoutException("Timeout of " + timeout + " sec reached.
Aborting");
+ LOGGER.info("Timeout of {} sec reached. Aborting", timeout);
Review Comment:
imo this should be info. It is doing exactly what the config is asking it to
do, and it ending here isn't an erroneous condition.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
