Jackie-Jiang commented on code in PR #8667:
URL: https://github.com/apache/pinot/pull/8667#discussion_r869576260
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3132,8 +3132,20 @@ public String startReplaceSegments(String
tableNameWithType, List<String> segmen
// Update segment lineage entry to 'REVERTED'
updateSegmentLineageEntryToReverted(tableNameWithType,
segmentLineage, entryId, lineageEntry);
+ // Update segmentsTo of the 'REVERTED' entry to handle the
following case:
Review Comment:
Can we merge this part with the `updateSegmentLineageEntryToReverted()`? In
most of the retry cases, the `segmentsTo` will be the same for both upload, and
we may directly remove the existing `IN_PROGRESS` entry instead of making it
`REVERTED` but with empty `segmentsTo`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
