jtao15 commented on code in PR #8667:
URL: https://github.com/apache/pinot/pull/8667#discussion_r869696463
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3132,8 +3132,20 @@ public String startReplaceSegments(String
tableNameWithType, List<String> segmen
// Update segment lineage entry to 'REVERTED'
updateSegmentLineageEntryToReverted(tableNameWithType,
segmentLineage, entryId, lineageEntry);
+ // Update segmentsTo of the 'REVERTED' entry to handle the
following case:
Review Comment:
If we only have partial overlapping for the segmentsTo, we still need to
mark it as `REVERTED`. I've merged the logic into
`updateSegmentLineageEntryToReverted()` and renamed as
`deleteORUpdateSegmentLineageEntryToReverted()`. Updated the comments to list
both examples to make it clear.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
