Jackie-Jiang commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r886126520
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java:
##########
@@ -84,6 +127,23 @@ public DateTimeFormatSpec(int columnSize, String
columnUnit, String columnTimeFo
_patternSpec = new DateTimeFormatPatternSpec(columnTimeFormat);
}
+ /**
+ * Constructs a dateTimeSpec format, given the components of a format
+ */
+ public DateTimeFormatSpec(String columnTimeFormat, String columnUnit, int
columnSize) {
Review Comment:
We won't use this constructor to construct the `DateTimeFormatSpec`. The
main constructor should be the one with single string as input, and we should
support both delimiters within that constructor (already done in this PR)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
