Jackie-Jiang commented on code in PR #8779:
URL: https://github.com/apache/pinot/pull/8779#discussion_r887218963
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/DateTimeFormatSpec.java:
##########
@@ -84,6 +127,23 @@ public DateTimeFormatSpec(int columnSize, String
columnUnit, String columnTimeFo
_patternSpec = new DateTimeFormatPatternSpec(columnTimeFormat);
}
+ /**
+ * Constructs a dateTimeSpec format, given the components of a format
+ */
+ public DateTimeFormatSpec(String columnTimeFormat, String columnUnit, int
columnSize) {
Review Comment:
Ideally we shouldn't construct the format from the constructor that already
have the parsed fields provided. But that is an existing problem and not
introduced in this PR, and we can solve that separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
