walterddr commented on code in PR #9143:
URL: https://github.com/apache/pinot/pull/9143#discussion_r936086746
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryConfig.java:
##########
@@ -22,9 +22,11 @@
* Configuration for setting up query runtime.
*/
public class QueryConfig {
- public static final int DEFAULT_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
128 * 1024 * 1024;
public static final long DEFAULT_TIMEOUT_NANO = 10_000_000_000L;
+ public static final String KEY_OF_MAX_INBOUND_QUERY_DATA_BLOCK_BYTES_SIZE =
"pinot.query.runner.max.msg.size";
Review Comment:
you mean the config key value or the static variable name?
- the variable is already within the multistage `QueryConfig` class so it
should be good.
- I use `pinot.query.runner` prefix to differentiate between normal query
and multi-stage query runner, but yeah I am open to other key naming convension
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
