walterddr commented on code in PR #9143:
URL: https://github.com/apache/pinot/pull/9143#discussion_r936087394
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/GrpcSendingMailbox.java:
##########
@@ -48,6 +49,11 @@ public void init()
PinotMailboxGrpc.PinotMailboxStub stub = PinotMailboxGrpc.newStub(channel);
_statusStreamObserver = new MailboxStatusStreamObserver();
_statusStreamObserver.init(stub.open(_statusStreamObserver));
+ // send a begin-of-stream message.
+ _statusStreamObserver.send(MailboxContent.newBuilder()
Review Comment:
if the mailbox sender/receiver pair is planned but the first message
contains exception. the mailbox will not be closed until timeout. this will
result in stall mailbox objects and potentially unclosed grpc connections.
so we send the first begin-of-stream message that guarantees no error will
occur with that payload, thus establish the connection (it is like a handshake
on the mailbox layer)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
