walterddr commented on code in PR #9148:
URL: https://github.com/apache/pinot/pull/9148#discussion_r936127366
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/SegmentDeletionManager.java:
##########
@@ -335,7 +335,7 @@ private long getDeletionTimeMsFromFile(String targetFile,
long lastModifiedTime)
}
@Nullable
- private static Long getRetentionMsFromTableConfig(@Nullable TableConfig
tableConfig) {
+ public static Long getRetentionMsFromTableConfig(@Nullable TableConfig
tableConfig) {
Review Comment:
yes the util was only used within SegmentDeletionManager but now we need to
expose it to not just segment but table utils.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
