walterddr commented on code in PR #9148:
URL: https://github.com/apache/pinot/pull/9148#discussion_r936127659
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -417,7 +417,9 @@ public String alterTableStateOrListTableConfig(
@ApiOperation(value = "Deletes a table", notes = "Deletes a table")
public SuccessResponse deleteTable(
@ApiParam(value = "Name of the table to delete", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Retention period for the table segments (e.g. 12h,
3d); Using 0d or -1d will instantly "
Review Comment:
good idea. see my suggested change below
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -417,7 +417,9 @@ public String alterTableStateOrListTableConfig(
@ApiOperation(value = "Deletes a table", notes = "Deletes a table")
public SuccessResponse deleteTable(
@ApiParam(value = "Name of the table to delete", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr) {
+ @ApiParam(value = "realtime|offline") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Retention period for the table segments (e.g. 12h,
3d); Using 0d or -1d will instantly "
+ + "delete segments without retention") @QueryParam("retention")
String retentionPeriod) {
Review Comment:
```suggestion
@ApiParam(value = "Retention period for the table segments (e.g. 12h,
3d); "
+ " If not set, the retention period will default to cluster
setting; Using 0d or -1d will instantly "
+ "delete segments without retention.") @QueryParam("retention")
String retentionPeriod) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
