jadami-stripe commented on code in PR #9244:
URL: https://github.com/apache/pinot/pull/9244#discussion_r955456966
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java:
##########
@@ -1429,15 +1429,17 @@ private void setConsumeEndTime(SegmentZKMetadata
segmentZKMetadata, long now) {
}
}
- private void fetchLatestStreamOffset() {
- try (StreamMetadataProvider metadataProvider = _streamConsumerFactory
- .createPartitionMetadataProvider(_clientId, _partitionGroupId)) {
- _latestStreamOffsetAtStartupTime =
-
metadataProvider.fetchStreamPartitionOffset(OffsetCriteria.LARGEST_OFFSET_CRITERIA,
/*maxWaitTimeMs*/5000);
+ public StreamPartitionMsgOffset fetchLatestStreamOffset() {
+ long maxWaitTimeMs = 5000;
Review Comment:
I'd prefer to leave as is for now since this is how it was working. It's a
minimal change if/when anyone else needs it configurable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
