jadami-stripe commented on code in PR #9244:
URL: https://github.com/apache/pinot/pull/9244#discussion_r955458900
##########
pinot-spi/src/main/java/org/apache/pinot/spi/utils/CommonConstants.java:
##########
@@ -386,6 +386,15 @@ public static class Server {
"pinot.server.starter.enableRealtimeOffsetBasedConsumptionStatusChecker";
public static final boolean
DEFAULT_ENABLE_REALTIME_OFFSET_BASED_CONSUMPTION_STATUS_CHECKER = false;
+ public static final String
CONFIG_OF_ENABLE_REALTIME_FRESHNESS_BASED_CONSUMPTION_STATUS_CHECKER =
Review Comment:
I had it this way in a previous iteration but went back for a few reasons:
- @navina suggested this approach
- the behaviors here aren't orthogonal. The freshness checker is strictly
more robust than the offset checker. If you enable both, getting the more
robust one is perfectly acceptable from an operational standpoint (in my
opinion)
- both of these are disabled by default. anyone running pinot today is at
most using the offset based checker. so they would be taking a tangible action
to enable the freshness checker meaning it's what they wanted enabled anyway.
Having the server fail at startup because of this seems like poor UX
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
