klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r963977609
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -546,6 +553,31 @@ File getSegmentDataDir(String segmentName) {
return new File(_indexDir, segmentName);
}
+ @VisibleForTesting
+ File getSegmentDataDir(String segmentName, String segmentTier,
IndexLoadingConfig indexLoadingConfig) {
+ if (segmentTier == null) {
+ return getSegmentDataDir(segmentName);
+ }
+ try {
+ String tierDataDir = TierConfigUtils
+ .getDataDirFromTierConfig(_tableNameWithType, segmentTier,
indexLoadingConfig.getTableConfig());
+ File tierTableDataDir = new File(tierDataDir, _tableNameWithType);
+ return new File(tierTableDataDir, segmentName);
+ } catch (Exception e) {
+ LOGGER.warn("Failed to get dataDir for segment: {} of table: {} on tier:
{} due to error: {}", segmentName,
+ _tableNameWithType, segmentTier, e.getMessage());
+ return getSegmentDataDir(segmentName);
+ }
+ }
+
+ private String getSegmentCurrentTier(String segmentName) {
Review Comment:
kk, I thought those annotations are for public methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
