klsince commented on code in PR #9306:
URL: https://github.com/apache/pinot/pull/9306#discussion_r964223310
##########
pinot-core/src/main/java/org/apache/pinot/core/data/manager/BaseTableDataManager.java:
##########
@@ -406,9 +410,12 @@ public void addOrReplaceSegment(String segmentName,
IndexLoadingConfig indexLoad
localMetadata.getCrc(), zkMetadata.getCrc());
}
File indexDir = downloadSegment(segmentName, zkMetadata);
- addSegment(indexDir, indexLoadingConfig);
- LOGGER.info("Downloaded and loaded segment: {} of table: {} with crc: {}",
segmentName, _tableNameWithType,
- zkMetadata.getCrc());
+ Schema schema = ZKMetadataProvider.getTableSchema(_propertyStore,
_tableNameWithType);
Review Comment:
actually, we can change it as below so it loads segment to local tier by
default, although this method is not used any more.
```
addSegment(ImmutableSegmentLoader.load(indexDir, indexLoadingConfig, schema,
true, _tableDataDir, null));
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
