GSharayu commented on code in PR #9309: URL: https://github.com/apache/pinot/pull/9309#discussion_r969850739
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/BaseSegmentAssignment.java: ########## @@ -68,11 +68,15 @@ public abstract class BaseSegmentAssignment implements SegmentAssignment { protected String _tableNameWithType; protected int _replication; protected String _partitionColumn; + protected TableConfig _tableConfig; + protected Map<InstancePartitionsType, SegmentAssignmentStrategy> _assignmentStrategyMap; @Override - public void init(HelixManager helixManager, TableConfig tableConfig) { + public void init(HelixManager helixManager, TableConfig tableConfig, + Map<InstancePartitionsType, InstancePartitions> instancePartitionsMap) { _helixManager = helixManager; _tableNameWithType = tableConfig.getTableName(); + _tableConfig = tableConfig; Review Comment: Not sure if I still understand this comment, we are using `_tableConfig ` in setSegmentAssignmentStrategyMap which is called from both RealtimeSegmentAssignment and OfflineSegmentAssignment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org