GSharayu commented on code in PR #9309: URL: https://github.com/apache/pinot/pull/9309#discussion_r969867675
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/ReplicaGroupSegmentAssignmentStrategy.java: ########## @@ -0,0 +1,135 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment.segment.strategy; + +import java.util.ArrayList; +import java.util.Collections; +import java.util.List; +import java.util.Map; +import java.util.Random; +import java.util.TreeMap; +import org.apache.helix.HelixManager; +import org.apache.pinot.common.assignment.InstancePartitions; +import org.apache.pinot.controller.helix.core.assignment.segment.SegmentAssignmentUtils; +import org.apache.pinot.spi.config.table.ReplicaGroupStrategyConfig; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.config.table.assignment.InstancePartitionsType; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +class ReplicaGroupSegmentAssignmentStrategy implements SegmentAssignmentStrategy { + private static final Logger LOGGER = LoggerFactory.getLogger(ReplicaGroupSegmentAssignmentStrategy.class); + + private static HelixManager _helixManager; + private static String _tableName; + private static String _partitionColumn; + private int _replication; + private TableConfig _tableConfig; + + @Override + public void init(HelixManager helixManager, TableConfig tableConfig) { + _helixManager = helixManager; + _tableConfig = tableConfig; + _tableName = tableConfig.getTableName(); + _replication = tableConfig.getValidationConfig().getReplicationNumber(); + ReplicaGroupStrategyConfig replicaGroupStrategyConfig = + tableConfig.getValidationConfig().getReplicaGroupStrategyConfig(); + _partitionColumn = replicaGroupStrategyConfig != null ? replicaGroupStrategyConfig.getPartitionColumn() : null; + if (_partitionColumn == null) { + LOGGER.info("Initialized ReplicaGroupSegmentAssignmentStrategy " + + "with replication: {} without partition column for table: {} ", _replication, _tableName); + } else { + LOGGER.info("Initialized ReplicaGroupSegmentAssignmentStrategy " + + "with replication: {} and partition column: {} for table: {}", + _replication, _partitionColumn, _tableName); + } + } + + /** + * Assigns the segment for the replica-group based segment assignment strategy and returns the assigned instances. + */ + @Override + public List<String> assignSegment(String segmentName, Map<String, Map<String, String>> currentAssignment, + InstancePartitions instancePartitions, InstancePartitionsType instancePartitionsType) { + int numPartitions = instancePartitions.getNumPartitions(); + SegmentAssignmentStrategyUtils.checkReplication(instancePartitions, _replication, _tableName); + int partitionId; + if (_partitionColumn == null || numPartitions == 1) { + partitionId = 0; + } else { + // Uniformly spray the segment partitions over the instance partitions + if (_tableConfig.getTableType() == TableType.OFFLINE) { + partitionId = + SegmentAssignmentUtils + .getOfflineSegmentPartitionId(segmentName, _tableName, _helixManager, _partitionColumn) % numPartitions; Review Comment: partitionId function is calculated different for Realtime and Offline Segment Assignments. I tried refactoring but it seems more complicated to merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
