GSharayu commented on code in PR #9309: URL: https://github.com/apache/pinot/pull/9309#discussion_r971262433
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/RealtimeSegmentAssignment.java: ########## @@ -182,9 +185,21 @@ public Map<String, Map<String, String>> rebalanceTable(Map<String, Map<String, S boolean bootstrap = config.getBoolean(RebalanceConfigConstants.BOOTSTRAP, RebalanceConfigConstants.DEFAULT_BOOTSTRAP); + // TODO: remove this check after we also refactor consuming segments assignment strategy + // See https://github.com/apache/pinot/issues/9047 + SegmentAssignmentStrategy segmentAssignmentStrategy = null; + if (completedInstancePartitions != null) { Review Comment: There are already set of preconditions to check not null before reassigning segments and tiers, so we are not expected to see completedInstancePartitions = null, I have added precondition check in segment assignment strategy factory -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org