GSharayu commented on code in PR #9309: URL: https://github.com/apache/pinot/pull/9309#discussion_r970163218
########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/SegmentAssignmentStrategyFactory.java: ########## @@ -0,0 +1,109 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment.segment.strategy; + +import com.google.common.base.Preconditions; +import java.util.Map; +import org.apache.helix.HelixManager; +import org.apache.pinot.common.assignment.InstancePartitions; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.config.table.assignment.InstancePartitionsType; +import org.apache.pinot.spi.config.table.assignment.SegmentAssignmentConfig; +import org.apache.pinot.spi.utils.CommonConstants.Segment.AssignmentStrategy; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Factory for SegmentAssignmentStrategy + */ +public class SegmentAssignmentStrategyFactory { + + private static final Logger LOGGER = LoggerFactory.getLogger(SegmentAssignmentStrategyFactory.class); + private SegmentAssignmentStrategyFactory() { + } + + /** + * Determine Segment Assignment strategy + */ + public static SegmentAssignmentStrategy + getSegmentAssignmentStrategy(HelixManager helixManager, + TableConfig tableConfig, InstancePartitions instancePartitions) { Review Comment: updated ########## pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/assignment/segment/strategy/SegmentAssignmentStrategyFactory.java: ########## @@ -0,0 +1,110 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.pinot.controller.helix.core.assignment.segment.strategy; + +import java.util.HashMap; +import java.util.Map; +import org.apache.helix.HelixManager; +import org.apache.pinot.common.assignment.InstancePartitions; +import org.apache.pinot.spi.config.table.TableConfig; +import org.apache.pinot.spi.config.table.TableType; +import org.apache.pinot.spi.config.table.assignment.InstancePartitionsType; +import org.apache.pinot.spi.config.table.assignment.SegmentAssignmentConfig; +import org.apache.pinot.spi.utils.CommonConstants.Segment.AssignmentStrategy; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + + +/** + * Factory for SegmentAssignmentStrategy + */ +public class SegmentAssignmentStrategyFactory { + + private static final Logger LOGGER = LoggerFactory.getLogger(SegmentAssignmentStrategyFactory.class); + private SegmentAssignmentStrategyFactory() { + } + + /** + * Determine Segment Assignment strategy + */ + public static Map<InstancePartitionsType, SegmentAssignmentStrategy> + getSegmentAssignmentStrategy(HelixManager helixManager, + TableConfig tableConfig, Map<InstancePartitionsType, InstancePartitions> instancePartitionsMap) { + String assignmentStrategy = null; + Map<InstancePartitionsType, SegmentAssignmentStrategy> segmentAssignmentStrategyMap = new HashMap<>(); + + TableType currentTableType = tableConfig.getTableType(); + // TODO: Handle segment assignment strategy in future for CONSUMING segments in follow up PR + InstancePartitionsType instancePartitionsType = currentTableType == TableType.OFFLINE + ? InstancePartitionsType.OFFLINE + : InstancePartitionsType.COMPLETED; + + // Accommodate new changes for assignment strategy + Map<String, SegmentAssignmentConfig> + segmentAssignmentConfigMap = tableConfig.getSegmentAssignmentConfigMap(); + + if (tableConfig.isDimTable()) { + // Segment Assignment Strategy for DIM tables + SegmentAssignmentStrategy segmentAssignmentStrategy = new DimTableSegmentAssignmentStrategy(); + segmentAssignmentStrategy.init(helixManager, tableConfig); + segmentAssignmentStrategyMap.put(instancePartitionsType, segmentAssignmentStrategy); + return segmentAssignmentStrategyMap; + } else { + // Try to determine segment assignment strategy from table config + if (segmentAssignmentConfigMap != null) { + SegmentAssignmentConfig segmentAssignmentConfig; + // Use the pre defined segment assignment strategy + segmentAssignmentConfig = segmentAssignmentConfigMap.get(instancePartitionsType.toString()); Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org
