jackjlli commented on PR #9423: URL: https://github.com/apache/pinot/pull/9423#issuecomment-1251422186
> It doesn't handle the scenario where a segment is manually deleted. I don't think it's a good idea to manually delete segments when segments are being queried. The better way is to disable them before doing the deletion. > Requiring users to add filters in the query isn't tenable. I'm not saying we should ask users to do that but your client system to append the predicate in the filter clause. > and the alternative is to automatically prune such segments in the Broker. But that's not doable right now since Broker doesn't watch TableConfig changes (retention may be changed by users). I'm not sure I fully understand your statement here. Pruning segments has nothing to do with table config changes. And in fact table config is already cached in broker, and there is a watcher in TableCache to listen the table config changes in ZK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
