chenboat commented on code in PR #9423:
URL: https://github.com/apache/pinot/pull/9423#discussion_r975690122
##########
pinot-core/src/main/java/org/apache/pinot/core/query/executor/ServerQueryExecutorV1Impl.java:
##########
@@ -291,12 +293,18 @@ private DataTable processQueryInternal(ServerQueryRequest
queryRequest, Executor
//
// After step 2 but before step 4, segment will be missing on server side
// TODO: Change broker to watch both IdealState and ExternalView to not
query the removed segments
- int numMissingSegments = missingSegments.size();
- if (numMissingSegments != 0) {
-
dataTable.addException(QueryException.getException(QueryException.SERVER_SEGMENT_MISSING_ERROR,
- String.format("%d segments %s missing on server: %s",
numMissingSegments, missingSegments,
- _instanceDataManager.getInstanceId())));
- _serverMetrics.addMeteredTableValue(tableNameWithType,
ServerMeter.NUM_MISSING_SEGMENTS, numMissingSegments);
+ if (unAcquiredSegments.size() > 0) {
Review Comment:
Add unit tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
