siddharthteotia commented on code in PR #9497:
URL: https://github.com/apache/pinot/pull/9497#discussion_r984094036


##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/AggregateNode.java:
##########
@@ -54,4 +54,9 @@ public List<RexExpression> getAggCalls() {
   public List<RexExpression> getGroupSet() {
     return _groupSet;
   }
+
+  @Override
+  public String debugString() {

Review Comment:
   In the existing engine, we implement `toExplainString` at the physical 
operator level and each operator also has a EXPLAIN_NAME. 
   
   Even in this case, I think the API could be called `explainString` or 
something similar even though we are doing at the logical node level and not at 
the operator level. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to