siddharthteotia commented on code in PR #9497:
URL: https://github.com/apache/pinot/pull/9497#discussion_r984095507
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/AggregateNode.java:
##########
@@ -54,4 +54,9 @@ public List<RexExpression> getAggCalls() {
public List<RexExpression> getGroupSet() {
return _groupSet;
}
+
+ @Override
+ public String debugString() {
Review Comment:
Ohh I just noticed this is not wired into the EXPLAIN PLAN. We do support
EXPLAIN (just the logical at this point) for multi-stage btw. We can probably
also do this by wiring this up with EXPLAIN PLAN for multi-stage (can do as a
follow up as well).
The output in the description looks reasonably good
##########
pinot-query-planner/src/main/java/org/apache/pinot/query/planner/stage/AggregateNode.java:
##########
@@ -54,4 +54,9 @@ public List<RexExpression> getAggCalls() {
public List<RexExpression> getGroupSet() {
return _groupSet;
}
+
+ @Override
+ public String debugString() {
Review Comment:
Ohh I just noticed this is not wired into the EXPLAIN PLAN. We do support
EXPLAIN (just the logical at this point iirc) for multi-stage btw. We can
probably also do this by wiring this up with EXPLAIN PLAN for multi-stage (can
do as a follow up as well).
The output in the description looks reasonably good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
