somandal commented on code in PR #9740: URL: https://github.com/apache/pinot/pull/9740#discussion_r1015953213
########## pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java: ########## @@ -62,34 +62,42 @@ import static org.apache.pinot.segment.spi.V1Constants.MetadataKeys.Column.DICTIONARY_ELEMENT_SIZE; import static org.apache.pinot.segment.spi.V1Constants.MetadataKeys.Column.HAS_DICTIONARY; import static org.apache.pinot.segment.spi.V1Constants.MetadataKeys.Column.getKeyFor; + + /** * Helper class used by {@link SegmentPreProcessor} to make changes to forward index and dictionary configs. Note * that this handler only works for segment versions >= 3.0. Support for segment version < 3.0 is not added because * majority of the usecases are in versions >= 3.0 and this avoids adding tech debt. The currently supported * operations are: * 1. Change compression on raw SV and MV columns. + * 2. Disable forward index on a column where it is enabled Review Comment: done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org For additional commands, e-mail: commits-h...@pinot.apache.org