siddharthteotia commented on code in PR #9740:
URL: https://github.com/apache/pinot/pull/9740#discussion_r1017685585
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/defaultcolumn/BaseDefaultColumnHandler.java:
##########
@@ -226,17 +226,19 @@ Map<String, DefaultColumnAction>
computeDefaultColumnActionMap() {
// Column exists in the segment, check if we need to update the value.
if (_segmentWriter != null && !columnMetadata.isAutoGenerated()) {
- // Check that forward index disabled isn't enabled / disabled on an
existing column (not auto-generated).
- // TODO: Add support for reloading segments when forward index
disabled flag is enabled or disabled
+ // Check that forward index disabled flag isn't disabled on an
existing column which had it enabled earlier
+ // (not auto-generated).
+ // TODO: Add support for reloading segments when forward index
disabled flag is disabled for a segment which
Review Comment:
(nit) suggest changing this to `TODO: Add support for recreating forward
index for a column with forward index disabled.` Will make it more readable imo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
