siddharthteotia commented on code in PR #9740:
URL: https://github.com/apache/pinot/pull/9740#discussion_r1017730180
##########
pinot-segment-local/src/test/java/org/apache/pinot/segment/local/segment/index/loader/SegmentPreProcessorTest.java:
##########
@@ -1903,19 +1908,76 @@ public void
testForwardIndexDisabledOnExistingColumnDictEncoded()
ColumnMetadata columnMetadata =
segmentMetadata.getColumnMetadataFor(EXISTING_STRING_COL_DICT);
assertNotNull(columnMetadata);
- SegmentDirectory segmentDirectory =
SegmentDirectoryLoaderRegistry.getDefaultSegmentDirectoryLoader()
- .load(_indexDir.toURI(),
- new
SegmentDirectoryLoaderContext.Builder().setSegmentDirectoryConfigs(_configuration).build());
- SegmentPreProcessor v3Processor =
- new SegmentPreProcessor(segmentDirectory, _indexLoadingConfig,
_newColumnsSchemaWithForwardIndexDisabled);
- expectThrows(RuntimeException.class, v3Processor::process);
+ createAndValidateIndex(ColumnIndexType.FORWARD_INDEX,
EXISTING_STRING_COL_DICT, 9, 4,
+ _newColumnsSchemaWithForwardIndexDisabled, false, true, false, 26,
true, 0, null, true, DataType.STRING,
+ 100000);
constructV1Segment(Collections.emptyList(), Collections.emptyList(),
Collections.emptyList());
- segmentDirectory =
SegmentDirectoryLoaderRegistry.getDefaultSegmentDirectoryLoader().load(_indexDir.toURI(),
- new
SegmentDirectoryLoaderContext.Builder().setSegmentDirectoryConfigs(_configuration).build());
- SegmentPreProcessor v1Processor =
- new SegmentPreProcessor(segmentDirectory, _indexLoadingConfig,
_newColumnsSchemaWithForwardIndexDisabled);
- expectThrows(RuntimeException.class, v1Processor::process);
+
+ createAndValidateIndex(ColumnIndexType.FORWARD_INDEX,
EXISTING_STRING_COL_DICT, 9, 4,
Review Comment:
For disabling forward index on a raw column, I gave a comment earlier about
whether to update tableConfig. Since we will implicitly create dictionary, in
that range index will have to be reconstructed.
But first we may want to discuss what to do for disabling forward index on
raw column
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
