walterddr commented on code in PR #9755:
URL: https://github.com/apache/pinot/pull/9755#discussion_r1019242021


##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -76,7 +83,7 @@ public DataSchema getDataSchema() {
    *
    * @return data container.
    */
-  public List<Object[]> getContainer() {

Review Comment:
   @agavra this involved changing the contain API from List to Collection. to 
support PriorityQueue pre-sorted intermediate result blocks. 



##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/blocks/TransferableBlock.java:
##########
@@ -76,7 +83,7 @@ public DataSchema getDataSchema() {
    *
    * @return data container.
    */
-  public List<Object[]> getContainer() {

Review Comment:
   @agavra this involved changing the container API from List to Collection. to 
support PriorityQueue pre-sorted intermediate result blocks. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org

Reply via email to