walterddr commented on code in PR #9755:
URL: https://github.com/apache/pinot/pull/9755#discussion_r1019473008
##########
pinot-core/src/main/java/org/apache/pinot/core/common/datablock/DataBlockBuilder.java:
##########
@@ -110,8 +109,8 @@ public static RowDataBlock buildFromRows(List<Object[]>
rows, DataSchema dataSch
nullPlaceholders[colId] =
columnDataTypes[colId].convert(storedColumnDataTypes[colId].getNullPlaceholder());
}
rowBuilder._numRows = rows.size();
- for (int rowId = 0; rowId < rows.size(); rowId++) {
- Object[] row = rows.get(rowId);
+ int rowId = 0;
+ for (Object[] row : rows) {
Review Comment:
missed place when revert from collection<object[]> back to list<object[]>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@pinot.apache.org
For additional commands, e-mail: commits-h...@pinot.apache.org
