KKcorps commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1025588073
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/mergerollup/MergeRollupTaskGenerator.java:
##########
@@ -571,6 +577,40 @@ private List<PinotTaskConfig>
createPinotTaskConfigs(List<SegmentZKMetadata> sel
return pinotTaskConfigs;
}
+ private Map<String, String> getPushTaskConfig(Map<String, String>
batchConfigMap, String downloadUrls) {
+ try {
+ String[] downloadURLList =
downloadUrls.split(MinionConstants.SEGMENT_NAME_SEPARATOR);
+ if (downloadURLList.length > 0) {
+ String downloadUrl = downloadURLList[0];
+ URI downloadURI = URI.create(downloadUrl);
+ URI outputDirURI = null;
+ if (!downloadURI.getScheme().contentEquals("http")) {
Review Comment:
Because the segment needs to be copied to some place that is accessible by
the controller in case of metadata push.
If user doesn't set the outputDirUri then the best place would be to copy it
in deep store. The download url refers to deep store path and hence using it to
derive the metadata.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
