zhtaoxiang commented on code in PR #9825:
URL: https://github.com/apache/pinot/pull/9825#discussion_r1028352023
##########
pinot-plugins/pinot-minion-tasks/pinot-minion-builtin-tasks/src/main/java/org/apache/pinot/plugin/minion/tasks/MinionTaskUtils.java:
##########
@@ -67,7 +72,35 @@ static PinotFS getOutputPinotFS(Map<String, String>
taskConfigs, URI fileURI)
return PinotFSFactory.create(fileURIScheme);
}
- static PinotFS getLocalPinotFs() {
+ public static Map<String, String> getPushTaskConfig(String tableName,
Map<String, String> taskConfigs,
+ ClusterInfoAccessor clusterInfoAccessor) {
+ try {
+ URI outputDirURI = URI.create(clusterInfoAccessor.getDataDir() + "/" +
tableName);
Review Comment:
I think we should check push mode first before deciding the outputDir?
If push mode is tar, we simply need to build segment locally and tar push to
Pinot.
Let me know if I misunderstood something
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
