deemoliu commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1060844976
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/BasePartitionUpsertMetadataManager.java:
##########
@@ -162,6 +165,9 @@ protected abstract void
addOrReplaceSegment(ImmutableSegmentImpl segment, Thread
Iterator<RecordInfo> recordInfoIterator, @Nullable IndexSegment
oldSegment,
@Nullable MutableRoaringBitmap validDocIdsForOldSegment);
+ protected abstract void removeExpiredPrimaryKeys(IndexSegment segment,
Iterator<RecordInfo> recordInfoIterator,
Review Comment:
@navina this method is similar to `addOrReplaceSegment()` method that is
being called internally by replaceSegment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
