Jackie-Jiang commented on code in PR #10047:
URL: https://github.com/apache/pinot/pull/10047#discussion_r1107573616
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/upsert/ConcurrentMapPartitionUpsertMetadataManager.java:
##########
@@ -181,6 +184,32 @@ protected void removeSegment(IndexSegment segment,
MutableRoaringBitmap validDoc
}
}
+ /**
+ * When TTL is enabled for upsert, this function is used to remove expired
keys from the primary key indexes.
+ *
+ * When committing consuming segment, we replaced the consuming segment with
an immutable segments.
Review Comment:
IIRC, we want to ensure the state for each replica to be the same. If we
don't sync on the cleanup, each replica will potentially have different result,
which can cause problem for upsert because during segment commit the segment
can come from another server
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
