saurabhd336 commented on code in PR #10088:
URL: https://github.com/apache/pinot/pull/10088#discussion_r1066738177
##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotTableRestletResource.java:
##########
@@ -847,16 +847,19 @@ private JsonNode getAggregateMetadataFromServer(String
tableNameWithType, List<S
notes = "Get list of controller jobs for this table")
public Map<String, Map<String, String>> getControllerJobs(
@ApiParam(value = "Name of the table", required = true)
@PathParam("tableName") String tableName,
- @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr
- ) {
+ @ApiParam(value = "OFFLINE|REALTIME") @QueryParam("type") String
tableTypeStr,
+ @ApiParam(value = "Comma separated list of job types")
@QueryParam("jobTypes") @Nullable String jobTypesString) {
TableType tableTypeFromRequest = Constants.validateTableType(tableTypeStr);
List<String> tableNamesWithType =
ResourceUtils.getExistingTableNamesWithType(_pinotHelixResourceManager,
tableName, tableTypeFromRequest,
LOGGER);
-
+ Set<String> jobTypesToFilter = null;
+ if (StringUtils.isNotEmpty(jobTypesString)) {
+ jobTypesToFilter = new
HashSet<>(java.util.Arrays.asList(StringUtils.split(jobTypesString, ",")));
Review Comment:
Ack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
