Jackie-Jiang commented on code in PR #10088:
URL: https://github.com/apache/pinot/pull/10088#discussion_r1068502508
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/IngestionConfigHybridIntegrationTest.java:
##########
@@ -217,6 +222,46 @@ public void testQueries()
Assert.assertEquals(response.get("resultTable").get("rows").size(), 0);
}
+ @Test
+ public void testForceCommit()
Review Comment:
Thanks for adding the test! Suggest moving it into
`LLCRealtimeClusterIntegrationTest` since it has nothing to do with ingestion
config
##########
pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/PinotHelixResourceManager.java:
##########
@@ -3610,6 +3628,21 @@ private void waitForSegmentsBecomeOnline(String
tableNameWithType, Set<String> s
tableNameWithType, segmentsToCheck));
}
+ public Set<String> getSegmentsFromIdealStateMatchingState(String
tableNameWithType,
Review Comment:
I prefer the previous version `getOnlineSegmentsFromIdealState(String
tableNameWithType, boolean includeConsuming)` for simplicity and efficiency. It
will be very rare to ask for segments other than ONLINE/CONSUMING.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
