walterddr commented on code in PR #10117:
URL: https://github.com/apache/pinot/pull/10117#discussion_r1068807753
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryDispatcher.java:
##########
@@ -86,19 +90,29 @@ public int submit(long requestId, QueryPlan queryPlan, long
timeoutMs)
String host = serverInstance.getHostname();
int servicePort = serverInstance.getQueryServicePort();
DispatchClient client = getOrCreateDispatchClient(host, servicePort);
- Worker.QueryResponse response =
client.submit(Worker.QueryRequest.newBuilder().setStagePlan(
+ Future<Worker.QueryResponse> response =
client.submit(Worker.QueryRequest.newBuilder().setStagePlan(
Review Comment:
no thread is used. it is sequential. e.g. clientFutureStub.submit returns
immediately with a Future that will be filled by GRPC executor thread in the
future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
