agavra commented on code in PR #10117:
URL: https://github.com/apache/pinot/pull/10117#discussion_r1069668657
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/service/QueryServer.java:
##########
@@ -45,13 +48,16 @@ public class QueryServer extends
PinotQueryWorkerGrpc.PinotQueryWorkerImplBase {
private final Server _server;
private final QueryRunner _queryRunner;
+ private final ExecutorService _executorService;
public QueryServer(int port, QueryRunner queryRunner) {
_server = ServerBuilder.forPort(port).addService(this).build();
_queryRunner = queryRunner;
+ _executorService =
Executors.newFixedThreadPool(ResourceManager.DEFAULT_QUERY_RUNNER_THREADS,
Review Comment:
Having different thread pools makes sense if there's potential deadlocking,
but it also can make the problems much more difficult to debug. Ideally we make
everything non-blocking and then we don't need to worry about that and we can
just use a single thread pool
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
