jugomezv commented on code in PR #10106:
URL: https://github.com/apache/pinot/pull/10106#discussion_r1070086597
##########
pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/ControllerPeriodicTasksIntegrationTest.java:
##########
@@ -206,8 +207,8 @@ public void testSegmentStatusChecker()
int numTables = 5;
ControllerMetrics controllerMetrics =
_controllerStarter.getControllerMetrics();
TestUtils.waitForCondition(aVoid -> {
- if (controllerMetrics
-
.getValueOfGlobalGauge(ControllerGauge.PERIODIC_TASK_NUM_TABLES_PROCESSED,
"SegmentStatusChecker")
+ if (MetricValueUtils.getGaugeValue(controllerMetrics,
+ ControllerGauge.PERIODIC_TASK_NUM_TABLES_PROCESSED.getGaugeName() +
".SegmentStatusChecker")
Review Comment:
Similar comment here, it is best to leave this as a task name argument, at
least then you can enforce naming that sticks to some convention there and not
let anybody who adds new stuff come up with a new way to concatenate names
across the code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
