zhtaoxiang commented on PR #10106: URL: https://github.com/apache/pinot/pull/10106#issuecomment-1386272418
> Also can we test at least one metric in each category to make sure they are emitted properly on a live system? Not sure if I understand you comment. There is no metric emission logic change in this PR, but only metric reading logic used in unit tests. Therefore, I think we don't need to test on a live system. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
