61yao commented on PR #10099: URL: https://github.com/apache/pinot/pull/10099#issuecomment-1385759919
> lgtm overall. this should be a good first step. could we add a simple test? we are not able to test this because 1) integration test doesn't allow us to specify # of blocks 2) grpc mailbox test is not working since we have thread leak which I will fix later and test all of the cases 3) this PR is urgent because we are not able to return correct result when data load is large -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
