ankitsultana commented on code in PR #10099:
URL: https://github.com/apache/pinot/pull/10099#discussion_r1072511053
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/mailbox/channel/MailboxContentStreamObserver.java:
##########
@@ -75,7 +98,9 @@ public MailboxContentStreamObserver(GrpcMailboxService
mailboxService,
StreamObserver<Mailbox.MailboxStatus> responseObserver, boolean
isEnabledFeedback) {
_mailboxService = mailboxService;
_responseObserver = responseObserver;
- _receivingBuffer = new
ArrayBlockingQueue<>(DEFAULT_MAILBOX_QUEUE_CAPACITY);
+ // TODO: Replace unbounded queue with bounded queue when we have
backpressure in place.
+ // It is possible this will create high memory pressure since we have
memory leak issues.
+ _receivingBuffer = new LinkedBlockingQueue();
Review Comment:
> We were simply dropping data block and returning the wrong result.
I don't think a wrong result would be returned. Instead the errorContent
would be set using the error lock and subsequent polls on
`MailboxContentStreamObserver` would return the error.
Can you confirm how a wrong result can be returned?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
