siddharthteotia commented on code in PR #10228:
URL: https://github.com/apache/pinot/pull/10228#discussion_r1099562378
##########
pinot-query-planner/src/test/resources/queries/WindowFunction.json:
##########
@@ -0,0 +1,1245 @@
+{
+ "window_function_planning_tests": {
Review Comment:
So for a window `OVER(PARTITION BY col1 ...)` query with a filter on the
partition column col1 in the `WHERE` clause, does the filter actually get
pushed below the window implicitly or do we need to add a rule for that ?
In any case, this is not a must have and can be a follow-up if at all
needed. I just happen to vaguely recollect doing something similar elsewhere
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
