siddharthteotia commented on code in PR #10228:
URL: https://github.com/apache/pinot/pull/10228#discussion_r1099571018
##########
pinot-query-planner/src/test/resources/queries/Aggregates.json:
##########
@@ -0,0 +1,34 @@
+{
+ "aggregates_planning_tests": {
Review Comment:
(nit) If we are planning to keep query planning v/s query execution test
resource files separately, then we may want to rename this file to
AggregatePlans.json or something similar.
Alternatively, we can keep planning and execution tests in the same file
then we can probably restructure this
```
"queries": {
"planning_tests" : {
.........
}
"execution_tests": {
..........
}
}
```
In any case, need not necessarily do in this PR since we want to do the
runtime work soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
