Jackie-Jiang commented on code in PR #10260:
URL: https://github.com/apache/pinot/pull/10260#discussion_r1106502542
##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/index/loader/ForwardIndexHandler.java:
##########
@@ -93,8 +93,10 @@ public class ForwardIndexHandler extends BaseIndexHandler {
private final Schema _schema;
protected enum Operation {
- DISABLE_FORWARD_INDEX_FOR_DICT_COLUMN,
- DISABLE_FORWARD_INDEX_FOR_RAW_COLUMN,
+ DISABLE_FORWARD_INDEX_FOR_DICT_OR_RAW_COLUMN,
Review Comment:
This part is very complicated. Are we able to simplify the operations
allowed?
I feel we can simplify it by making changes in steps:
1. Check if we need to enable/disable dictionary (switch between dictionary
encoding and raw forward index)
2. Check if we need to enable/disable the forward index
3. Check if we need to change the raw index compression type
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
