somandal commented on PR #10260: URL: https://github.com/apache/pinot/pull/10260#issuecomment-1441159975
> LGTM with minor comments. > > Thanks for adding the detailed tests, but it will be good if we can merge some similar tests to keep the test smaller and with the same coverage. It should also help reduce the CI run time. Currently the total lines of test for the forward index handler is probably close to 5K lines, and is quite hard to manage. This can be addressed separately Thanks for the detailed review @Jackie-Jiang ! I've addressed most of your comments. Great point about the test explosion. Let me spend some time going over the tests in more detail and come up with that list which can be removed. I'll address this in a follow up (along with changes to remove that Operation enum). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
