walterddr commented on code in PR #10449:
URL: https://github.com/apache/pinot/pull/10449#discussion_r1147762062
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##########
@@ -239,16 +238,18 @@ private boolean consumeInputBlocks() {
return true;
}
+ Key emptyOrderKey = AggregationUtils.extractEmptyKey();
Review Comment:
i dont think we need to extract this on every block
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
