somandal commented on code in PR #10449:
URL: https://github.com/apache/pinot/pull/10449#discussion_r1147816723
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##########
@@ -239,16 +238,18 @@ private boolean consumeInputBlocks() {
return true;
}
+ Key emptyOrderKey = AggregationUtils.extractEmptyKey();
Review Comment:
good catch, fixed
##########
pinot-query-runtime/src/main/java/org/apache/pinot/query/runtime/operator/WindowAggregateOperator.java:
##########
@@ -239,16 +238,18 @@ private boolean consumeInputBlocks() {
return true;
}
+ Key emptyOrderKey = AggregationUtils.extractEmptyKey();
List<Object[]> container = block.getContainer();
for (Object[] row : container) {
_numRows++;
- // TODO: Revisit the aggregation logic once ORDER BY inside OVER()
support is added, also revisit null direction
- // handling for all query types
+ // TODO: Revisit null direction handling for all query types
Key key = AggregationUtils.extractRowKey(row, _groupSet);
+ Key orderKey = (CollectionUtils.isEmpty(_orderSetInfo.getOrderSet())
|| _orderSetInfo.isPartitionByOnly())
Review Comment:
good catch, fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
