xiangfu0 commented on code in PR #10468:
URL: https://github.com/apache/pinot/pull/10468#discussion_r1152725258
##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/SegmentMetadata.java:
##########
@@ -98,11 +100,11 @@ public interface SegmentMetadata {
String getEndOffset();
- default Set<String> getAllColumns() {
+ default NavigableSet<String> getAllColumns() {
Review Comment:
Shall we directly use TreeSet instead of NavigableSet if there is no other
implementation expected .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
