Jackie-Jiang commented on code in PR #10468:
URL: https://github.com/apache/pinot/pull/10468#discussion_r1153577066
##########
pinot-spi/src/main/java/org/apache/pinot/spi/data/Schema.java:
##########
@@ -650,22 +655,19 @@ public boolean equals(Object o) {
if (EqualityUtils.isSameReference(this, o)) {
return true;
}
-
if (EqualityUtils.isNullOrNotSameClass(this, o)) {
return false;
}
-
Schema that = (Schema) o;
-
- return EqualityUtils.isEqual(_schemaName, that._schemaName) &&
EqualityUtils
- .isEqualIgnoreOrder(_dimensionFieldSpecs, that._dimensionFieldSpecs)
&& EqualityUtils
- .isEqualIgnoreOrder(_metricFieldSpecs, that._metricFieldSpecs) &&
EqualityUtils
- .isEqual(_timeFieldSpec, that._timeFieldSpec) && EqualityUtils
- .isEqualIgnoreOrder(_dateTimeFieldSpecs, that._dateTimeFieldSpecs) &&
EqualityUtils
- .isEqualIgnoreOrder(_complexFieldSpecs, that._complexFieldSpecs) &&
EqualityUtils
- .isEqualMap(_fieldSpecMap, that._fieldSpecMap) && EqualityUtils
- .isEqual(_primaryKeyColumns, that._primaryKeyColumns) && EqualityUtils
- .isEqual(_hasJSONColumn, that._hasJSONColumn);
+ //@formatter:off
+ return EqualityUtils.isEqual(_schemaName, that._schemaName)
Review Comment:
They are derived fields (similarly we don't include `_dimensionNames` etc.).
Ideally we should define them as transient, but java ser/de still need to
serialize these fields.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
